Perl::Critic::Policy::ControlStructures::ProhibitUntilBlocks - Write while(! $condition)
instead of until($condition)
.
This Policy is part of the core Perl::Critic distribution.
Conway discourages using until
because it leads to double-negatives that are hard to understand. Instead, reverse the logic and use while
.
until($condition) { do_something() } #not ok
until(! $no_flag) { do_something() } #really bad
while( ! $condition) { do_something() } #ok
This Policy only covers the block-form of until
. For the postfix variety, see ProhibitPostfixControls
.
This Policy is not configurable except for the standard options.
Perl::Critic::Policy::ControlStructures::ProhibitPostfixControls
Jeffrey Ryan Thalhammer <jeff@imaginative-software.com>
Copyright (c) 2005-2011 Imaginative Software Systems. All rights reserved.
This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module.