package Perl::Critic::Policy::ControlStructures::ProhibitUntilBlocks; use 5.010001; use strict; use warnings; use Readonly; use Perl::Critic::Utils qw{ :severities }; use parent 'Perl::Critic::Policy'; our $VERSION = '1.152'; #----------------------------------------------------------------------------- Readonly::Scalar my $DESC => q{"until" block used}; Readonly::Scalar my $EXPL => [ 97 ]; #----------------------------------------------------------------------------- sub supported_parameters { return () } sub default_severity { return $SEVERITY_LOW } sub default_themes { return qw(core pbp cosmetic) } sub applies_to { return 'PPI::Statement' } #----------------------------------------------------------------------------- sub violates { my ( $self, $elem, undef ) = @_; if ( $elem->first_element() eq 'until' ) { return $self->violation( $DESC, $EXPL, $elem ); } return; #ok! } 1; __END__ #----------------------------------------------------------------------------- =pod =head1 NAME Perl::Critic::Policy::ControlStructures::ProhibitUntilBlocks - Write C instead of C. =head1 AFFILIATION This Policy is part of the core L distribution. =head1 DESCRIPTION Conway discourages using C because it leads to double-negatives that are hard to understand. Instead, reverse the logic and use C. until($condition) { do_something() } #not ok until(! $no_flag) { do_something() } #really bad while( ! $condition) { do_something() } #ok This Policy only covers the block-form of C. For the postfix variety, see C. =head1 CONFIGURATION This Policy is not configurable except for the standard options. =head1 SEE ALSO L =head1 AUTHOR Jeffrey Ryan Thalhammer =head1 COPYRIGHT Copyright (c) 2005-2011 Imaginative Software Systems. All rights reserved. This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module. =cut # Local Variables: # mode: cperl # cperl-indent-level: 4 # fill-column: 78 # indent-tabs-mode: nil # c-indentation-style: bsd # End: # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :