Perl::Critic::Policy::Objects::ProhibitIndirectSyntax - Prohibit indirect object call syntax.
This Policy is part of the core Perl::Critic distribution.
Indirect object syntax is commonly used in other object-oriented languages for instantiating objects. Perl allows this, but to say that it supports it may be going too far. Instead of writing
my $foo = new Foo;it is preferable to write
my $foo = Foo->new;The problem is that Perl needs to make a number of assumptions at compile time to disambiguate the first form, so it tends to be fragile and to produce hard-to-track-down bugs.
Indirect object syntax is also hard for Perl::Critic to disambiguate, so this policy only checks certain subroutine calls. The names of the subroutines can be configured using the forbid configuration option:
[Objects::ProhibitIndirectSyntax]
forbid = create destroyThe new subroutine is configured by default; any additional forbid values are in addition to new.
The general situation can not be handled via static analysis.
Perl::Critic::Policy::Dynamic::NoIndirect and indirect both do a better job with this, but they require that you compile/execute your code.
Thomas R. Wyant, III wyant at cpan dot org
Copyright (c) 2009-2023 Tom Wyant
This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module.