package Perl::Critic::Policy::ValuesAndExpressions::RequireInterpolationOfMetachars; use 5.010001; use strict; use warnings; use Readonly; use List::SomeUtils qw(any); use Perl::Critic::Utils qw< :booleans :characters :severities >; use parent 'Perl::Critic::Policy'; #----------------------------------------------------------------------------- our $VERSION = '1.152'; #----------------------------------------------------------------------------- Readonly::Scalar my $DESC => q; Readonly::Scalar my $EXPL => [ 51 ]; #----------------------------------------------------------------------------- sub supported_parameters { return ( { name => 'rcs_keywords', description => 'RCS keywords to ignore in potential interpolation.', default_string => $EMPTY, behavior => 'string list', }, ); } sub default_severity { return $SEVERITY_LOWEST } sub default_themes { return qw(core pbp cosmetic) } sub applies_to { return qw< PPI::Token::Quote::Single PPI::Token::Quote::Literal >; } #----------------------------------------------------------------------------- sub initialize_if_enabled { my ($self, $config) = @_; my $rcs_keywords = $self->{_rcs_keywords}; my @rcs_keywords = keys %{$rcs_keywords}; if (@rcs_keywords) { my $rcs_regexes = [ map { qr/ \$ $_ [^\n\$]* \$ /xms } @rcs_keywords ]; $self->{_rcs_regexes} = $rcs_regexes; } return $TRUE; } sub violates { my ( $self, $elem, undef ) = @_; # The string() method strips off the quotes my $string = $elem->string(); return if not _needs_interpolation($string); return if _looks_like_email_address($string); return if _looks_like_use_vars($elem); my $rcs_regexes = $self->{_rcs_regexes}; return if $rcs_regexes && any { $string =~ m/$_/xms } @{$rcs_regexes}; return $self->violation( $DESC, $EXPL, $elem ); } #----------------------------------------------------------------------------- sub _needs_interpolation { my ($string) = @_; return # Contains a $ or @ not followed by "{}". $string =~ m< [\$\@] (?! [{] [}] ) \S+ >xms # Contains metachars # Note that \1 ... are not documented (that I can find), but are # treated the same way as \0 by S_scan_const in toke.c, at least # for regular double-quotish strings. Not, obviously, where # regexes are involved. || $string =~ m< (?: \A | [^\\] ) (?: \\{2} )* \\ [tnrfbae01234567xcNluLUEQ] >xms; } #----------------------------------------------------------------------------- # Stolen from Email::Address, which is deprecated. Since we are not modifying # the original code at all, we are less stringent in being Critic-compliant. ## no critic ( RegularExpressions::RequireDotMatchAnything ) ## no critic ( RegularExpressions::RequireLineBoundaryMatching ) ## no critic ( RegularExpressions::ProhibitEscapedMetacharacters ) my $CTL = q{\x00-\x1F\x7F}; ## no critic ( ValuesAndExpressions::RequireInterpolationOfMetachars ) my $special = q{()<>\\[\\]:;@\\\\,."}; ## no critic ( ValuesAndExpressions::RequireInterpolationOfMetachars ) my $text = qr/[^\x0A\x0D]/x; my $quoted_pair = qr/\\$text/x; my $ctext = qr/(?>[^()\\]+)/x; my $ccontent = qr/$ctext|$quoted_pair/x; my $comment = qr/\s*\((?:\s*$ccontent)*\s*\)\s*/x; my $cfws = qr/$comment|\s+/x; my $atext = qq/[^$CTL$special\\s]/; my $dot_atom_text = qr/$atext+(?:\.$atext+)*/x; my $dot_atom = qr/$cfws*$dot_atom_text$cfws*/x; my $qtext = qr/[^\\"]/x; my $qcontent = qr/$qtext|$quoted_pair/x; my $quoted_string = qr/$cfws*"$qcontent*"$cfws*/x; my $local_part = qr/$dot_atom|$quoted_string/x; my $dtext = qr/[^\[\]\\]/x; my $dcontent = qr/$dtext|$quoted_pair/x; my $domain_literal = qr/$cfws*\[(?:\s*$dcontent)*\s*\]$cfws*/x; my $domain = qr/$dot_atom|$domain_literal/x; my $addr_spec = qr/$local_part\@$domain/x; sub _looks_like_email_address { my ($string) = @_; return if index ($string, q<@>) < 0; return if $string =~ m< \W \@ >xms; return if $string =~ m< \A \@ \w+ \b >xms; return $string =~ $addr_spec; } #----------------------------------------------------------------------------- sub _looks_like_use_vars { my ($elem) = @_; my $statement = $elem; while ( not $statement->isa('PPI::Statement::Include') ) { $statement = $statement->parent() or return; } return if $statement->type() ne q; return $statement->module() eq q; } 1; __END__ #----------------------------------------------------------------------------- =pod =for stopwords RCS =head1 NAME Perl::Critic::Policy::ValuesAndExpressions::RequireInterpolationOfMetachars - Warns that you might have used single quotes when you really wanted double-quotes. =head1 AFFILIATION This Policy is part of the core L distribution. =head1 DESCRIPTION This policy warns you if you use single-quotes or C with a string that has unescaped metacharacters that may need interpolation. Its hard to know for sure if a string really should be interpolated without looking into the symbol table. This policy just makes an educated guess by looking for metacharacters and sigils which usually indicate that the string should be interpolated. =head2 Exceptions =over =item * Variable names to C: use vars '$x'; # ok use vars ('$y', '$z'); # ok use vars qw< $a $b >; # ok =item * Things that look like e-mail addresses: print 'john@foo.com'; # ok $address = 'suzy.bar@baz.net'; # ok =back =head1 CONFIGURATION The C option allows you to stop this policy from complaining about things that look like RCS variables, for example, in deriving values for C<$VERSION> variables. For example, if you've got code like our ($VERSION) = (q<$Revision$> =~ m/(\d+)/mx); You can specify [ValuesAndExpressions::RequireInterpolationOfMetachars] rcs_keywords = Revision in your F<.perlcriticrc> to provide an exemption. =head1 NOTES Perl's own C pragma also warns you about this. =head1 SEE ALSO L =head1 AUTHOR Jeffrey Ryan Thalhammer =head1 COPYRIGHT Copyright (c) 2005-2023 Imaginative Software Systems. This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. The full text of this license can be found in the LICENSE file included with this module. =cut # Local Variables: # mode: cperl # cperl-indent-level: 4 # fill-column: 78 # indent-tabs-mode: nil # c-indentation-style: bsd # End: # ex: set ts=8 sts=4 sw=4 tw=78 ft=perl expandtab shiftround :